VK-GL-CTS icon indicating copy to clipboard operation
VK-GL-CTS copied to clipboard

Published 20 hours ago • verified publisher icon KhronosGroup

Support GL 4.5 in the 'negative' tests

Open mpiatyko opened this issue 2 years ago • 3 comments

This patch is port of 512fa1c1bc1930a1966df7caefb3c199ac02a919

Affects: dEQP-GL45-ES3.functional.negative_api.* dEQP-GLES3.functional.negative_api.*

Signed-off-by: Mykola Piatykop [email protected]

mpiatyko avatar Aug 03 '22 19:08 mpiatyko

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 03 '22 19:08 CLAassistant

Hi @alegal-arm , could you please look at this patch?

mpiatyko avatar Aug 10 '22 12:08 mpiatyko

Thank you for your contribution @mpiatyko, I will take this internally for review. Please note that I took over chair of the group last year from Alex.

mnetsch avatar Aug 10 '22 14:08 mnetsch

@mpiatyko Please make following changes and update:

  1. "dEQP-GL45-ES3.functional.negative_api.shader.get_program_binary" should be skipped for desktop OpenGL because it assumes a null fragment shader fails to link, which isn't the case for desktop OpenGL.

  2. All the dEQP-GL45-ES3.functional.negative_api.vertex_array.draw* tests are invalid because the call the glDraw* call from the core profile, but there is no VAO bound.

tpalli avatar Oct 26 '22 10:10 tpalli

@mpiatyko Please make following changes and update:

  1. "dEQP-GL45-ES3.functional.negative_api.shader.get_program_binary" should be skipped for desktop OpenGL because it assumes a null fragment shader fails to link, which isn't the case for desktop OpenGL.
  2. All the dEQP-GL45-ES3.functional.negative_api.vertex_array.draw* tests are invalid because the call the glDraw* call from the core profile, but there is no VAO bound.

Hi @tpalli, thank you for your comment.

  1. "dEQP-GL45-ES3.functional.negative_api.shader.get_program_binary" deleted from test suite for desktop OpenGL. Please see gles3: test suite update
  2. All failed dEQP-GL45-ES3.functional.negative_api.vertex_array.draw* tests are fixed by VAO binding for core profile. See Support GL 4.5 in the 'negative' tests. Please clarify if I understand your comment correctly.

mpiatyko avatar Nov 01 '22 10:11 mpiatyko

@mpiatyko Following tests do not have VAO bound before calling glDrawArrays :

dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_invalid_program
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_incomplete_primitive
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_instanced
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_instanced_invalid_program
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_instanced_incomplete_primitive

And thus are not valid. This is happening in ES3F_ADD_API_CASE(draw_arrays, "Invalid glDrawArrays() usage",. Please add VAO there as well.

tpalli avatar Nov 23 '22 05:11 tpalli

@mpiatyko Following tests do not have VAO bound before calling glDrawArrays :

dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_invalid_program
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_incomplete_primitive
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_instanced
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_instanced_invalid_program
dEQP-GL45-ES3.functional.negative_api.vertex_array.draw_arrays_instanced_incomplete_primitive

And thus are not valid. This is happening in ES3F_ADD_API_CASE(draw_arrays, "Invalid glDrawArrays() usage",. Please add VAO there as well.

Done

mpiatyko avatar Nov 24 '22 16:11 mpiatyko

Changes applied as https://github.com/KhronosGroup/VK-GL-CTS/commit/aafea513d6f6e7449b9c0906985f1096bf76fe6b

mnetsch avatar Jan 09 '23 18:01 mnetsch