GLSE2 functional_fbo_completeness_renderable_texture_color0_rgba_half_float_oes test seems invalid

[greggman]

AFAICT the test for dEQP.GLES2/functional_fbo_completeness_renderable_texture_color0_rgba_half_float_oes is in invalid

Here

https://github.com/KhronosGroup/VK-GL-CTS/blob/e2aeccde416b8a07f4d8425f26181130358e3bb2/modules/gles2/functional/es2fFboCompletenessTests.cpp#L166-L170

if GL_OES_texture_half_float exists then RGBA/HALF_FLOAT and RGB/HALF_FLOAT are added as texture formats to test and at that point they are expected to NOT be color-renderable

https://github.com/KhronosGroup/VK-GL-CTS/blob/e2aeccde416b8a07f4d8425f26181130358e3bb2/modules/gles2/functional/es2fFboCompletenessTests.cpp#L92-L97

Then a few lines down from the first lines above

https://github.com/KhronosGroup/VK-GL-CTS/blob/e2aeccde416b8a07f4d8425f26181130358e3bb2/modules/gles2/functional/es2fFboCompletenessTests.cpp#L213-L217

If these 3 extensions exist DEQP_gles3_core_compatible GL_OES_texture_half_float GL_EXT_color_buffer_half_float then the HALF formats just added above are updated to expect COLOR_RENDERABLE

The problem is this faux DEQP_gles3_core_compatible extension is basically checking if the GL is version 3.0 or better. but the other 2 extensions are perfectly valid 2.0 extension. Meaning, if you're on an OpenGL ES 2.0 implementation that supports both GL_OES_texture_half_float and GL_EXT_color_buffer_half_float this test will incorrectly fail

I believe a simple solution is just to delete DEQP_gles3_core_compatible from the requirements above.

[greggman]

@kenrussell

[imirkin]

I believe I have a solution to this waiting in a pull request since before this bug was filed: https://github.com/KhronosGroup/VK-GL-CTS/pull/283

I considered removing the gles3 requirement, but that seemed off -- GL_RGB is not allowed by the spec, only GL_RGBA. So instead I added a separate section just for this.

[tpalli]

I believe we should be able to close this issue now?