KHR-GL45.gpu_shader_fp64.fp64.varyings has undefined delete behaviour

[airlied]

Running with ASAN enabled I got this, looks like releaseXFBVaryingNames needs a delete[] instead of a delete.

Test case 'KHR-GL45.gpu_shader_fp64.fp64.varyings'..

==9303==ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs operator delete) on 0x606000257f60 #0 0x7fee33727a2f in operator delete(void*) (/usr/lib64/libasan.so.5+0x110a2f) #1 0x75bbfc in gl4cts::GPUShaderFP64Test7::releaseXFBVaryingNames() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x75bbfc) #2 0x756d7e in gl4cts::GPUShaderFP64Test7::buildTestProgram(std::vector<gl4cts::GPUShaderFP64Test7::_variable, std::allocatorgl4cts::GPUShaderFP64Test7::_variable >&) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x756d7e) #3 0x757884 in gl4cts::GPUShaderFP64Test7::executeFunctionalTest(std::vector<gl4cts::GPUShaderFP64Test7::_variable, std::allocatorgl4cts::GPUShaderFP64Test7::_variable >&) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x757884) #4 0x75b5fa in gl4cts::GPUShaderFP64Test7::iterate() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x75b5fa) #5 0x59a2e5 in gl3cts::TestCaseWrapper::iterate(tcu::TestCase*) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x59a2e5) #6 0x2c855bb in tcu::TestSessionExecutor::iterateTestCase(tcu::TestCase*) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x2c855bb) #7 0x2c845d6 in tcu::TestSessionExecutor::iterate() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x2c845d6) #8 0x2c52d80 in tcu::App::iterate() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x2c52d80) #9 0x589e67 in main (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x589e67) #10 0x7fee32ef5f42 in __libc_start_main (/lib64/libc.so.6+0x23f42) #11 0x589c5d in _start (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x589c5d)

0x606000257f60 is located 0 bytes inside of 56-byte region [0x606000257f60,0x606000257f98) allocated by thread T0 here: #0 0x7fee33726c97 in operator new[](unsigned long) (/usr/lib64/libasan.so.5+0x10fc97) #1 0x758257 in gl4cts::GPUShaderFP64Test7::generateXFBVaryingNames(std::vector<gl4cts::GPUShaderFP64Test7::_variable, std::allocatorgl4cts::GPUShaderFP64Test7::_variable > const&) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x758257) #2 0x756d97 in gl4cts::GPUShaderFP64Test7::buildTestProgram(std::vector<gl4cts::GPUShaderFP64Test7::_variable, std::allocatorgl4cts::GPUShaderFP64Test7::_variable >&) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x756d97) #3 0x757884 in gl4cts::GPUShaderFP64Test7::executeFunctionalTest(std::vector<gl4cts::GPUShaderFP64Test7::_variable, std::allocatorgl4cts::GPUShaderFP64Test7::_variable >&) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x757884) #4 0x75b5fa in gl4cts::GPUShaderFP64Test7::iterate() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x75b5fa) #5 0x59a2e5 in gl3cts::TestCaseWrapper::iterate(tcu::TestCase*) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x59a2e5) #6 0x2c855bb in tcu::TestSessionExecutor::iterateTestCase(tcu::TestCase*) (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x2c855bb) #7 0x2c845d6 in tcu::TestSessionExecutor::iterate() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x2c845d6) #8 0x2c52d80 in tcu::App::iterate() (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x2c52d80) #9 0x589e67 in main (/home/airlied/devel/VK-GL-CTS/build/external/openglcts/modules/glcts+0x589e67) #10 0x7fee32ef5f42 in __libc_start_main (/lib64/libc.so.6+0x23f42)