OpenXR-SDK-Source icon indicating copy to clipboard operation
OpenXR-SDK-Source copied to clipboard

disable OPENGL on macOS

Open kcking opened this issue 1 year ago • 4 comments

OpenGL is causing lots of compilation errors on macOS, and it is deprecated anyways, so it seems most pragmatic to me to just disable it.

My original PR built successfully with release-1.0.22, but once rebased on top of main, required this fix to compile successfully.

Let me know if this is desirable and I can tack on a change fragment as well. Thanks!

kcking avatar Aug 07 '22 05:08 kcking

So what graphics API are you using if you disabled OpenGL? Alternately is there a way to work out the fix to make it build again? Trying to think of what changed between 1.0.22 and 1.0.24 that might affect it, I can't say there was much software change I recall, would have to look at the changelog and diff

rpavlik avatar Aug 08 '22 14:08 rpavlik

Oh I have been using Vulkan -> Molten, I wasn't aware whether OpenGL on macOS was considered a supported platform combination. The reason I never tried it was because the libraries I'm using use wgpu which doesn't support OpenGL

kcking avatar Aug 09 '22 01:08 kcking

Ah ok. I'd still be interested in getting OpenGL build fixed.

rpavlik avatar Aug 09 '22 02:08 rpavlik

An issue (number 1807) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#1807 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

rpavlik-bot avatar Aug 10 '22 18:08 rpavlik-bot

Sorry for the noise, the build issues appear to have been a false alarm

kcking avatar Oct 08 '22 19:10 kcking

oh excellent! glad to hear it.

rpavlik avatar Oct 13 '22 17:10 rpavlik