OpenGL-Registry icon indicating copy to clipboard operation
OpenGL-Registry copied to clipboard

Update EXT_texture_format_BGRA8888.txt

Open kusma opened this issue 1 year ago • 5 comments

As agreed on today's call, let's make GL_BGRA8_EXT an allowed internalformat as well.

kusma avatar Feb 14 '24 16:02 kusma

What about the XML? I guess the only change is that this:

        <enum value="0x93A1" name="GL_BGRA8_EXT"/>

Should be:

        <enum value="0x93A1" name="GL_BGRA8_EXT" group="PixelFormat"/>

SunSerega avatar Feb 20 '24 19:02 SunSerega

@SunSerega you are right that it should be part of the PixelFormat group, but this fact is not changed by this PR and therefore is effectively out of scope. What would be in scope for this PR is adding the InternalFormat group as well, but given that neither group is present currently I suggest one of the XML editors fix this in a subsequent PR.

Perksey avatar Feb 20 '24 19:02 Perksey

By the way, I think I've come to the realization that the change in this MR needs to actually be an interaction with OpenGL ES 3.0, because in OpenGL ES 1.x and 2.x it's not really legal to use different formats and internalformats... This basically depends on sized internalformat support.

kusma avatar Feb 20 '24 21:02 kusma

By the way, I think I've come to the realization that the change in this MR needs to actually be an interaction with OpenGL ES 3.0, because in OpenGL ES 1.x and 2.x it's not really legal to use different formats and internalformats... This basically depends on sized internalformat support.

Actually, GLES 2 has some support for sized internalformats... But not to the full extent, so it seems better to limit this to OpenGL ES 3.0 and later... That's also where we see the problems in current implementations.

kusma avatar Feb 21 '24 08:02 kusma

CTS tests added here: https://github.com/KhronosGroup/VK-GL-CTS/pull/449

kusma avatar Feb 21 '24 15:02 kusma

lgtm, thankyou!

fooishbar avatar May 15 '24 11:05 fooishbar

WG has approved the latest version.

zmike avatar May 22 '24 15:05 zmike

WG has approved the latest version.

@zmike could you set the Signed Off milestone if that's what this means?

oddhack avatar May 27 '24 08:05 oddhack

WG has approved the latest version.

@zmike could you set the Signed Off milestone if that's what this means?

The comment was for the author. I'll set the milestone when this is ready to merge.

zmike avatar May 27 '24 13:05 zmike

The CTS tests landed in the Khronos GitLab repo. Is it time to merge this PR?

kusma avatar May 31 '24 12:05 kusma