OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

Refactor external semaphore scaffolding

Open gorazd-sumkovski-arm opened this issue 9 months ago • 1 comments

Remove the CREATE_OPENCL_SEMAPHORE macro and use derived class instantiations of the clExternalSemaphore class, rather than base pointers to derived class objects.

Remove the default argument for queryParamName in check_external_semaphore_handle_type().

Move check_external_semaphore_handle_type() checks to constructors of clExternalImportableSemaphore and clExternalExportableSemaphore, rather than manually making the check before creating an external semaphore.

gorazd-sumkovski-arm avatar Mar 06 '25 10:03 gorazd-sumkovski-arm

This passes for us, looks good

joshqti avatar Mar 25 '25 16:03 joshqti

Merging as agreed in memory subgroup call on April 15th, 2025.

nikhiljnv avatar Apr 16 '25 03:04 nikhiljnv