OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

Add tests for cl_ext_immutable_memory_objects

Open MichaelRizkalla-arm opened this issue 10 months ago • 3 comments

This change provides partial test coverage for KhronosGroup/OpenCL-Docs#1280

Adding CTS tests for:

  1. clEnqueueMapBuffer, clEnqueueMapImage.
  2. Command buffer negative tests.
  3. clSetKernelArgs negative tests.

The bulk of the tests is to make sure that the CL driver does not allow writing to a memory object that is created with CL_MEM_IMMUTABLE_EXT flag when used with the above APIs.

MichaelRizkalla-arm avatar Feb 20 '25 09:02 MichaelRizkalla-arm

Looks like this is another one where we'll need header changes before we can merge.

Would it be possible to get a draft headers PR up with these changes so this won't become a bottleneck once the tests have been reviewed?

bashbaug avatar Feb 25 '25 02:02 bashbaug

Thanks for the review.

There is a plan to add more tests to cover command queue's fills and copies and reading from buffers and images.

MichaelRizkalla-arm avatar Mar 03 '25 15:03 MichaelRizkalla-arm

Here's a PR adding definitions to the headers: https://github.com/KhronosGroup/OpenCL-Headers/pull/274

kpet avatar Mar 04 '25 09:03 kpet

Please re-add "focused review" once the merge conflicts are resolved.

bashbaug avatar May 06 '25 01:05 bashbaug

@MichaelRizkalla-arm Could you resolve the merge conflicts please?

kpet avatar May 06 '25 16:05 kpet

I have updated the PR to resolve the merge conflicts.

MichaelRizkalla-arm avatar May 07 '25 10:05 MichaelRizkalla-arm

Merging as discussed in the June 17th memory subgroup.

bashbaug avatar Jun 17 '25 17:06 bashbaug