OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

a few fixes (thread safety & cl_khr_command_buffer UB)

Open franz opened this issue 1 year ago • 2 comments

some fixes we've been carrying in our CTS fork:

  • fix UB in command_buffer_event_sync.cpp: enqueue of two commands in two separate queues, with both using the same buffer argument, and no synchronization between the commands.
  • fix UB in command_buffer_test_barrier.cpp: missing synchronization between zeroing command and command-buffer using two separate queues
  • make test_thread_dimensions.cpp thread-safe to avoid spurious errors.

franz avatar Nov 04 '23 18:11 franz

Removed the first two commits from the PR; i did not realize there was already an open PR with those.

franz avatar Dec 07 '23 15:12 franz

rebased on main. should be ready for review.

franz avatar Jan 18 '24 10:01 franz

Merging as discussed in the October 8th teleconference.

bashbaug avatar Oct 08 '24 16:10 bashbaug