OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

Published 20 hours ago • verified publisher icon KhronosGroup

Image streams optimization fixes

Open cdavis5e opened this issue 2 years ago • 6 comments

Fixes build for GCC 11.1-3, since they have the missing intrinsics now. Fixes #1637.

Fixes some broken shuffles and an add that gave wrong expected results. @alan-baker Should fix #1636.

Clearly, I should have tested my change more rigorously.

cdavis5e avatar Feb 16 '23 10:02 cdavis5e

I'm running a test now to check if I see any odd failures on my side.

No need--I already found some. I'm working on fixing them now.

cdavis5e avatar Feb 17 '23 23:02 cdavis5e

No need--I already found some. I'm working on fixing them now.

All right, I'm pretty sure I've fixed all the failures that were caused by my PR.

cdavis5e avatar Feb 19 '23 19:02 cdavis5e

Reviewing, thanks.

lakshmih avatar Feb 22 '23 16:02 lakshmih

Looks good to us.

lakshmih avatar Feb 27 '23 18:02 lakshmih

There haven't been any updates to this PR since the changes were reverted. I think we should remove "Focused Review".

bashbaug avatar Mar 28 '23 15:03 bashbaug

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Mar 05 '24 22:03 CLAassistant