KhronosGroup
Add clang-format support
This work if the continuation of #889.
Notes for the reviewers
Some comments from the original work addressed here, most notably:
- Limit column size of all formatted sources to 100.
Aside from explicit comments:
- A git-blame ignore file has been committed to the repo which instructs GitHub's blame functionality on the web interface to keep attribution of lines affected by formatting. Local clones may be configured told similarly.
- The functional changes are all outside the singular "Apply initial formatting" commit.
Should other formatting changes need refining, discussions may continue here.
I think this work is complete. The current CI failure doesn't seem to be related to the changes made here.
You need to rebase or merge main again to pick up the workaround for the build issue on GitHub Actions. The latest runner image is only partially fixed.
@MathiasMagnus please address the outstanding issues and complete this work.
@MarkCallow We created this PR out of courtesy, because this task did not fit in the original project timeline, so we are unable to address all the specific personal styling and tooling requests. I added documentation on the minimal requirement to reduce CI friction and noted how to configure VS Code to not trip CI. Vim is too deep a rabbit a hole and I don't have the time to give anything I document in XCode a test drive.
As for the rest of the outstanding formatting related inquiries: instead of whack-a-mole-ing the formatting issues one-by-one and aligning them to the desired format, I reverted the "Initial formatting" commit and just commit the machinery enabling the enforced formatting.
- For now, CI job definition is there, but its invocation is commented out.
- The GitHub-friendly git blame ignore file is there with a note but not hash.
Because clang-format can't run on an entire source tree, all the tools drive it file-by-file. Should you want to tweak the .clang-format files to perfection, I used the following one-liner on Windows:
# list folders excluding build and .venv | recurse into all | filter files matching regex | for each of the matches { run clang-format inplace using style files and full path to file }
gci -exc build,.venv | gci -rec | where -prop Name -match '^.*\.((((c|C)(c|pp|xx|\+\+)?$)|((h|H)h?(pp|xx|\+\+)?$))|(ino|pde|proto|cu))$' | % { clang-format.exe -i --style=file $_.FullName }
I leave implementing similar logic in the shell of their choice to the end-user. (The regex I borrowed from the script run by the CI action.)
In summary, all the infrastructure for clang-format is there, please tweak it for your needs as you see fit.
the understanding that due to the additional requests we ran out of time and budget to do the clang-format change
Were these "additional requests" related or unrelated to clang-format? If the former what where they?
There is no way to exclude individual files from formatting.
Because clang-format can't run on an entire source tree, all the tools drive it file-by-file.
These statements conflict. What am I missing?
There is no way to exclude individual files from formatting.
What about .clang-format-ignore which I've just discovered at https://clang.llvm.org/docs/ClangFormat.html.
the understanding that due to the additional requests we ran out of time and budget to do the clang-format change
Were these "additional requests" related or unrelated to clang-format? If the former what where they?
There is no way to exclude individual files from formatting.
Because clang-format can't run on an entire source tree, all the tools drive it file-by-file.
These statements conflict. What am I missing?
Edit: accidentally pressed the wrong button.
They do not conflict. clang-format, the CLI tool does run file-by-file (unless you run it with a script or indirectly through git clang-format, which is ran for all changed files), but the style sheets (the .clang-format files) apply to entire directories. You cannot change them file-by-file.
The only way to disable clang-format for a single file to either move it to a separate directory for which you disable the styling in the .clang-format file, or you modify the source to surround the content that is not supposed to be formatted with // clang-format off and // clang format on.
