COLLADA2GLTF icon indicating copy to clipboard operation
COLLADA2GLTF copied to clipboard

GLTF::Object should have a virtual destructor?

Open ziriax opened this issue 6 years ago • 1 comments

It is a common C++ design practice to always make destructors of base classes virtual, so that deleting a pointer to a base instance will call the derived constructor.

Do you guys agree? Then I'll make a patch request.

This would make fixing memory leaks in Maya2glTF easier by just keeping a vector of <GLTF::Object*>

ziriax avatar Dec 04 '18 11:12 ziriax

Seems like a good idea to me, happy to do a review of a PR.

lasalvavida avatar Dec 05 '18 14:12 lasalvavida