khiops icon indicating copy to clipboard operation
khiops copied to clipboard
verified publisher icon KhiopsML

Sign macOS binaries in CI

Open folmos-at-orange opened this issue 1 year ago • 2 comments

Description

The PR #214 added the osx-arm64 build for the conda khiops executables. Since in osx-arm64 non signed binaries add unwanted popups we should sign them.

Questions/Ideas

  • Add the macOS certificate to the secrets
  • Change the signature code in packaging/conda/build.shso it is signed only on request
    • Currently it is triggered by setting a specific environment variables.

folmos-at-orange avatar Apr 08 '24 13:04 folmos-at-orange

After discussion in weekly:

  • Put secrets in vault immediatly
  • Put the signature flag afterwards solving this issue.

folmos-at-orange avatar Apr 10 '24 09:04 folmos-at-orange

After thinking about it even just putting the secrets in the vault needs a change in the code. So I think I'll leave all this work for later.

folmos-at-orange avatar Apr 10 '24 12:04 folmos-at-orange

Done in PR #330 and #332

lucaurelien avatar Jul 04 '24 13:07 lucaurelien