aphrodite Enable buffer methods before needing to call StyleSheetServer.renderStatic

Enable buffer methods before needing to call StyleSheetServer.renderStatic

Open DaBs opened this issue 6 years ago • 9 comments

Currently, Aphrodite assumes that it is the first server-side module to render the tree, but since StyleSheetServer.renderStatic expects a string as return value, it eliminates any possibility of walking the reference with another module.

This PR borrows some of the TestUtils functions to allow a, albeit a bit clunky, method of avoiding having to append classes to the DOM while walking an existing reference to a tree.

Aug 31 '18 15:08 DaBs

Hey @DaBs,

Thanks for the PR! Mind signing our Contributor License Agreement?

When you've done so, go ahead and comment [clabot:check] and I'll check again.

Yours truly, khanbot

Aug 31 '18 15:08 khanbot

[clabot:check]

Aug 31 '18 15:08 DaBs

CLA signature looks good :+1:

Aug 31 '18 15:08 khanbot

@lencioni I believe you guys have been in need of a fix to this as per https://github.com/Khan/aphrodite/issues/326. Is this something you would consider reviewing?

Sep 01 '18 14:09 DaBs

@jlfwong Is this something you know if people within the project has time to look at? I believe it's quite a nice way of giving some manual tools for people to be able to temporarily suspend aphrodite style rendering when it comes to SSR.

Sep 19 '18 00:09 DaBs

I'm running into this issue as well! Any chance this will be merged & released any time soon? :)