aphrodite icon indicating copy to clipboard operation
aphrodite copied to clipboard

Use csstype

Open pelotom opened this issue 7 years ago • 1 comments

csstype is a set of standard, high-quality CSS typings generated from MDN data. It is now being used by the React and JSS typings. It would be great to have the entire CSS-in-JS ecosystem standardize on these typings rather than each project maintaining its own pet CSS typings, each with varying degrees of completeness and usually inconsistent with one another!

pelotom avatar Apr 04 '18 01:04 pelotom

I'd be open to a PR which updates the CSS typings to use csstype :)

For reference, the PR that changed the CSS typings for React to use csstype: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24688

It seems like this isn't as battle tested as the existing types that we're using from https://github.com/paypal/glamorous/blob/master/typings/css-properties.d.ts, but the fact that this is going to be the semi-official types for React is pretty compelling.

jlfwong avatar Apr 04 '18 02:04 jlfwong