sttm-web icon indicating copy to clipboard operation
sttm-web copied to clipboard

auto substitute (as option) letters in first letter/main letter search

Open ManjotS opened this issue 7 years ago • 16 comments

all the pair bindis should be found with normal letters

ManjotS avatar Jan 15 '18 21:01 ManjotS

open oora with normal

ManjotS avatar Jan 15 '18 21:01 ManjotS

@tarunsingh5 can you create a mapping of this for me?

ie ਸ => ਸ਼

ManjotS avatar Feb 10 '18 03:02 ManjotS

but in ascii not unicode

ManjotS avatar Feb 10 '18 03:02 ManjotS

should this be done in the api or should this be done in the app? for example w/ khakha we did this in the app

tarunsingh5 avatar Mar 13 '18 22:03 tarunsingh5

this should have been done in the api

On Tue, Mar 13, 2018 at 3:00 PM, Tarun Singh [email protected] wrote:

should this be done in the api or should this be done in the app? for example w/ khakha we did this in the app

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/BaniDB-API/issues/23#issuecomment-372833557, or mute the thread https://github.com/notifications/unsubscribe-auth/AAnXFYxMZt8DlIz0cIl8ZQkhiw4IUZgOks5teEGGgaJpZM4Re-VI .

ManjotS avatar Mar 13 '18 22:03 ManjotS

so i actually think it should be done in the app b/c the user should have the option to use the fuzzy mapping or not and we should keep the api as explicit as possible

@navdeepsinghkhalsa thoughts?

tarunsingh5 avatar Mar 13 '18 22:03 tarunsingh5

agree @tarunsingh5 (lets add the fuzzy ticket to sttm-web and close this)

ManjotS avatar Jul 05 '18 17:07 ManjotS

This one is high priority - I have to type in pairi KHAKHA to get KHALSA MERO ROOP HAI KHAAS. A regular KHAKHA should also find this. Same for other bindhi characters. image

saintsoldierx avatar Oct 10 '20 08:10 saintsoldierx

The substitution itself should be part of anvaad, so web can just include anvaad. It may have already been implemented. Good question for irvanjit singh.

ManjotS avatar Oct 12 '20 15:10 ManjotS

There's a few optional flags for this implemented in the firstLetter and mainLetter functions. Documented on the anvaad readme @ManjotS @saintsoldierx

irvanjitsingh avatar Jan 05 '21 16:01 irvanjitsingh

Would love it if we can get this one done too @gsin11

https://github.com/KhalisFoundation/anvaad-js for the readme

saintsoldierx avatar Apr 18 '21 06:04 saintsoldierx

For this, we would want those pehar bindhi akhars to show only if searching in Gurmukhi and only is searching full words. Not first letter. The other thing is if someone types any of those characters with a pehar bindhi, such as ਸ then it should also seatch ਸ਼. Goes for all 5 letters.

saintsoldierx avatar Apr 23 '21 04:04 saintsoldierx

@saintsoldierx if that's the intended usecase, then firstLetter/mainLetter columns should be regenerated with the 'simplify' flag enabled in anvaad. this will replace all ਸ਼ with ਸ, etc. Since full word search doesn't use the firstLetter or mainLetter columns, it would be unaffected and searching for ਸ would give ਸ and ਸ਼ would give ਸ਼. Also, note that regenerating firstLetter's with the flag is only one part, the query string would also require the same logic to be applied to replace characters. This can be added in anvaad as well or implemented in sttm.

irvanjitsingh avatar Feb 15 '22 04:02 irvanjitsingh

@ManjotS something you can take up? If this can be done using simplify flag, then let's do it at Anvaad level?

saintsoldierx avatar Oct 28 '22 20:10 saintsoldierx

@ManjotS @saintsoldierx We wants to continue with this ?

gurjit03 avatar Jul 19 '24 06:07 gurjit03

@ManjotS @saintsoldierx We wants to continue with this ?

Yes, it's been outstanding for a while

saintsoldierx avatar Jul 19 '24 06:07 saintsoldierx