sttm-desktop icon indicating copy to clipboard operation
sttm-desktop copied to clipboard

export to pdf

Open tarunsingh5 opened this issue 7 years ago • 11 comments
trafficstars

STTM2 provided ability to open the entire shabad in a window or PDF. Provide ability to split the display similar to STTM2 website.

tarunsingh5 avatar Jan 12 '18 20:01 tarunsingh5

  • [x] Provide Full Shabad View (like website), with toggle in display settings
  • [x] Add Split View (like website)
  • [x] Add export to PDF function

ManjotS avatar Jan 18 '18 18:01 ManjotS

Should full Shabad view be limited to exporting and not be an option in the app as a view option? I personally think so. Split view doesn't really make sense in this presentation app.

@inderpreetsingh We shouldn't build this into the webview/BrowserWindow display and then export, but rather at the app level. Please keep in mind that we have the power of node and shouldn't feel limited by what's possible in the browser.

navdeepsinghkhalsa avatar Feb 21 '18 17:02 navdeepsinghkhalsa

I think we still need to show some print preview, to give some feedback to user on what it's going to print and how it would look like. User might wanna change display settings before printing. It would be hard to fathom from slide view on what split view would look like in print.

What way do you suggest on app level? using .printToPDF seemed really simple and official way to print pdf of window content in electron. (Looking at other apps and documentation) I am not that well versed in best practices in electron. Let me know and I will add commits to this PR.

inderpreetsingh avatar Feb 23 '18 11:02 inderpreetsingh

I agree that we need to show a print preview, but I don't think the main or presenter windows are the places to do it. Let's open up a new window specifically for print preview, show the options on the left and the preview on the right. As the options are toggled on the left, the preview updates on the right. Here's an example and the PDF library that we can use to build the PDF. http://pdfmake.org/playground.html If you would like, I can set you up in your branch with a baseline of how to do it and you can continue it, or we can set up a chat or discuss here. Let me know!

navdeepsinghkhalsa avatar Feb 26 '18 04:02 navdeepsinghkhalsa

@navdeepsinghkhalsa Yes, a baseline I believe would be really helpful. Thanks :)

inderpreetsingh avatar Feb 27 '18 06:02 inderpreetsingh

is this in 4.0.2? @navdeepsinghkhalsa @inderpreetsingh

tarunsingh5 avatar Jul 04 '18 20:07 tarunsingh5

@tarunsingh5 It is not

navdeepsinghkhalsa avatar Jul 13 '18 01:07 navdeepsinghkhalsa

Is this in Dev or not @navdeepsinghkhalsa ? If not, can it be reassigned please

saintsoldierx avatar Sep 16 '18 22:09 saintsoldierx

@maneetpaul @inderpreetsingh was this ever launched?

tarunsingh5 avatar Jul 19 '19 19:07 tarunsingh5

Not to my knowledge @tarunsingh5 - will circle back to this

maneetpaul avatar Jul 19 '19 22:07 maneetpaul

@saintsoldierx can you provide a lofi design for this option?

prebhdevsingh avatar Mar 15 '21 16:03 prebhdevsingh