banidb-api icon indicating copy to clipboard operation
banidb-api copied to clipboard

Search for Bindi characters alongwith the normal words

Open Gauravjeetsingh opened this issue 1 year ago • 4 comments

Earlier when searched for /search/Kmrh?source=all&searchtype=1&writer=all&page=1 we got 0 results, but with this fix, we get the following response image

Would work for all five bindi characters.

  • 'ਸ਼'
  • 'ਖ਼'
  • 'ਗ਼'
  • 'ਜ਼'
  • 'ਫ਼'

Gauravjeetsingh avatar Apr 17 '24 22:04 Gauravjeetsingh

It works for simple search, but if we use wildchar characters like *, it doesn't work, I will look into that tomorrow.

Update: Adding it alongwith the wildchar search operators require complex refactoring, we can do that as a separate issue.

Gauravjeetsingh avatar Apr 18 '24 02:04 Gauravjeetsingh

@Gauravjeetsingh please update this and let's merge it for everyone.

indersinghkhalis avatar Mar 06 '25 20:03 indersinghkhalis

@inderpreetsingh I dont have access to merge this, I have tested it on my local and it works fine. You can go ahead and merge if you have the access.

Gauravjeetsingh avatar Mar 07 '25 19:03 Gauravjeetsingh

@indersinghkhalis veerji I still can't merge this, looks like it needs approval from one more reviewer. If you have access, can you merge?

Gauravjeetsingh avatar Apr 23 '25 09:04 Gauravjeetsingh