banidb-api icon indicating copy to clipboard operation
banidb-api copied to clipboard

Add total number lines changed since

Open AkalUstat opened this issue 5 years ago • 12 comments

If a GET request is submitted to /shabads/updates/{INSERT DATE}, the total verses changed since that date is displayed

AkalUstat avatar Jul 15 '20 23:07 AkalUstat

What's the use case for this?

tsingh777 avatar Jul 15 '20 23:07 tsingh777

i have an idea for updating a locally downloded db after some updates w/o releasing a new version like sundae gutka does

AkalUstat avatar Jul 16 '20 02:07 AkalUstat

How does the count help, though? Wouldn't you just the appropriate endpoint for what you want to pull?

navdeepsinghkhalsa avatar Jul 16 '20 02:07 navdeepsinghkhalsa

pull after a certain amt of changes

AkalUstat avatar Jul 16 '20 02:07 AkalUstat

@ManjotS does the Updated column behave the way this PR is expecting?

tsingh777 avatar Jul 16 '20 02:07 tsingh777

its ok if its not really needed i can find some other way

AkalUstat avatar Jul 16 '20 04:07 AkalUstat

Yes updated is updated when the line changes in any way. Keep in mind it could be translit change.

On Wed, Jul 15, 2020, 9:07 PM Akal-Ustat Singh [email protected] wrote:

its ok if its not really needed i can find some other way

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/KhalisFoundation/banidb-api/pull/202#issuecomment-659145511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE5OFJPE3RVVEH4NPOSSS3R3Z4HTANCNFSM4O3FADBQ .

ManjotS avatar Jul 16 '20 04:07 ManjotS

maybe this isnt the best solution

AkalUstat avatar Jul 16 '20 05:07 AkalUstat

is this WIP?

ManjotS avatar Sep 09 '20 20:09 ManjotS

it is done but not sure if needed/wanted

AkalUstat avatar Sep 09 '20 23:09 AkalUstat

bump @tsingh777 @navdeepsinghkhalsa do you guys think this is useful to have or we can do without?

AkalUstat avatar Oct 26 '20 17:10 AkalUstat

@AkalUstat wouldnt a fixed # of line changes lead to fewer and fewer updates? ie as the db gets better youd wait longer and longer b/c there are less lines that will need changing

tarunsingh5 avatar Jan 12 '21 09:01 tarunsingh5