AxonCore icon indicating copy to clipboard operation
AxonCore copied to clipboard

BUG: Prompt is not collecting any message

Open taOsemc opened this issue 3 years ago • 3 comments

BUG REPORT

Overview

Prompt is not collecting any message.

Description

Issue state:

  • [ ] I know how to fix this and I will open a PR to do so
  • [ X ] I am just reporting the issue

Details:
This issue is about:

  • [ ] Typings
  • [ ] Documentation
  • [ X ] Bug in existing feature
  • [ ] Missing feature / breaking change
  • [ ] API / library update
  • [ ] None of the above (don't know what the issue is about)

Additional information:

  • Node.js version: V12.18
  • AxonCore version: 2.1
  • Library used: (discordjs)

taOsemc avatar Oct 06 '20 09:10 taOsemc

Thanks for the report. As discussed in discord, this is because Prompt has not been switched to AxonCore Collectors. That means it won't work with djs.

This will be fixed in a future commit:

  • switching Prompt to AxonCore Collector for greatly increased performances
  • lib-agnostic design for Prompt

⚠️ Technical warning: API may change slightly for Prompt. Typically, we will need to instantiate a Prompt with a MessageCollector in param.

Khaaz avatar Oct 06 '20 09:10 Khaaz

Should be fixed: https://github.com/Khaaz/AxonCore/pull/109/commits/c8dfdf3bc39bea0994b731a9e8db7c4ec8e45466

taOsemc avatar Oct 12 '20 09:10 taOsemc

Temporary fixed in 320a060 Prompt will be refactored to use MessageCollector.

Khaaz avatar Oct 14 '20 12:10 Khaaz