keystone3-firmware
keystone3-firmware copied to clipboard
feat: change coinType for agoric from 564 to 118
Explanation
First of all, thank you for supporting Agoric chain on Keystone.
When I started using my keystone device, I noticed that the address for Agoric chain on my Keystone 3 Pro is different from the address on my Ledger Nano X, even though they share the same seed phrases.
Upon some digging, it seems like in this situation the coinType should be 118 instead of 564. Here are some relevant comments I found:
My rough understanding is that 564 is a coin type we registered, but it's necessary to use 118, the default cosmos coinType, in certain interop situations; in particular, when using a ledger.
From: https://github.com/Agoric/agoric-sdk/discussions/5830#discussioncomment-5071717
PS: let me know if there are other places where I should update the coinType
Pre-merge check list
- [ ] PR run build successfully on local machine.
- [ ] All unit tests passed locally.
Remark: could you point me to some documentations on how to run tests on a Mac with Apple Silicon?
How to test
Not sure what's the best way to test this. I'm also not sure if the keystone device would cache the address generated with cointype 564 somewhere?