keystone3-firmware
keystone3-firmware copied to clipboard
Request for ERC20 approvals to be displayed in decimal rather than hex
When signing a spending approval on an ERC20, the details tab will represent the approval amount in hex. This could be more clear for users if this value was displayed in decimal.
In the attached screenshot, I submitted and approval for 1.2345
on a 4 decimal ERC20 that I had deployed on a testnet. However, in firmware 1.2.4 on hardware v3 this value was shown as 3039
.
Reproduction steps:
- Setup Keystone v3
- Bind to MetaMask (v11.7.2 tested with Chrome 117.0.5938.92)
- Select Keystone address as active
- Be on testnet
- Go to test dapp
- Connect
- Scroll down to
Send tokens
section and tapCREATE TOKEN
- Once confirmed, Add it to wallet with
ADD TOKEN(S) TO WALLET
- tap
APPROVE TOKENS
cta in test dapp - edit the amount if you chose
- Tap
Next
in MetaMask - Tap
Approve
in MetaMask - Open MetaMask again bc open issue
- Scan QR with Keystone
- Tap details tab and scroll down