android icon indicating copy to clipboard operation
android copied to clipboard

bumped sync timer to 5500

Open 0x4f53 opened this issue 2 years ago • 3 comments

:recycle: Current situation

The network call timer thread executed too frequently, causing Volley to suffer from a memory leak from inconclusive requests.

:bulb: Proposed solution

Increase the timer interval to 5500ms.

📷 Screenshots

NA

📚 Release Notes

  • Changed the timer interval to 5500ms.

📝 Testing

  • Start the Keyspace app, make sure your vault has entries.
  • Keep the app open for 15 minutes and check if the app is still up and running in the foreground.
  • Tell me if it crashes or not in the comments.

0x4f53 avatar Feb 08 '23 05:02 0x4f53

@4f77616973 It seems to work fine up to 15 min. I had a crash between 20-25 min. Trying to recreate it again to get a more accurate time.

rohan-chaturvedi avatar Feb 08 '23 08:02 rohan-chaturvedi

Any updates on this?

0x4f53 avatar Feb 10 '23 06:02 0x4f53

Any updates on this?

I'm still getting a crash around the 20 min mark. If 15 min is an acceptable window then we can go ahead with this, but it doesn't seem to be addressing the root cause of the crash. Also weirdly, I don't get the crash log dialog when it crashes.

rohan-chaturvedi avatar Feb 13 '23 05:02 rohan-chaturvedi