guzzle-cache-middleware POST request strategy key support

Will solve: https://github.com/Kevinrob/guzzle-cache-middleware/issues/170

Jan 26 '23 14:01 Legion112

@Kevinrob any feedback?

Jan 30 '23 06:01 Legion112

Sure I will created a separate SR with only docker commit.

Jun 05 '23 17:06 Legion112

Here: https://github.com/Kevinrob/guzzle-cache-middleware/pull/179

Jun 06 '23 08:06 Legion112

It is strange that you have a way to set the cache methods

https://github.com/Kevinrob/guzzle-cache-middleware/blob/0e12dccf3c811a18bb2f6c93882c5b5727e1b859/src/CacheMiddleware.php#LL98C21-L98C35 \Kevinrob\GuzzleCache\CacheMiddleware::setHttpMethods

If you think the library should not allow to set cache for post method and others why not drop this method to prevent users from misusing it?

Jun 06 '23 08:06 Legion112

It is strange that you have a way to set the cache methods

https://github.com/Kevinrob/guzzle-cache-middleware/blob/0e12dccf3c811a18bb2f6c93882c5b5727e1b859/src/CacheMiddleware.php#LL98C21-L98C35 \Kevinrob\GuzzleCache\CacheMiddleware::setHttpMethods

If you think the library should not allow to set cache for post method and others why not drop this method to prevent users from misusing it?

Yeah, that's because this lib can be extended with custom strategies. The strategies that are bundle with it respect the RFC, but people can use it as they want.

Jun 14 '23 11:06 Kevinrob

I am not longer interested in this change.

Feb 20 '24 18:02 Legion112