compose-webview-multiplatform icon indicating copy to clipboard operation
compose-webview-multiplatform copied to clipboard

Ktor 3.0.0-beta-1 support

Open artalejo opened this issue 1 year ago • 2 comments

Hello there,

In my KMM project I am currently using Ktor 3.0.0-beta-1 version for several reasons, the problem is that when compiling and trying to open a webview in my compose desktop app an issue with the Content Negotiation arises.

java.lang.NoClassDefFoundError: io/ktor/client/plugins/contentnegotiation/ContentNegotiation at dev.datlag.kcef.step.fetch.PackageDownloader$downloadPackage$client$1.invoke(PackageDownloader.kt:39) at dev.datlag.kcef.step.fetch.PackageDownloader$downloadPackage$client$1.invoke(PackageDownloader.kt:37) at io.ktor.client.HttpClientKt.HttpClient(HttpClient.kt:42)

artalejo avatar May 26 '24 20:05 artalejo

@DatL4g Could you have a look at this issue?

KevinnZou avatar May 29 '24 10:05 KevinnZou

On Backlog until there is a stable release

DatL4g avatar May 29 '24 19:05 DatL4g

Any change here folks?

SamC-Apadmi avatar Oct 14 '24 16:10 SamC-Apadmi

+1 here, getting same error on 3.0.0

mixeden avatar Oct 14 '24 19:10 mixeden

I've just used v1.6.0 for now and that works. @DatL4g I'm happy to create a PR on KCEF and on this repo if you'd be able to review them? If you're offline completely at the moment though I'll hold off

SamC-Apadmi avatar Oct 15 '24 08:10 SamC-Apadmi

@SamC-Apadmi please go ahead, I'll review it

DatL4g avatar Oct 15 '24 09:10 DatL4g

@DatL4g PR open here. If you're happy and we can get a build out of that library I'll then PR into this repo for that change.

SamC-Apadmi avatar Oct 15 '24 11:10 SamC-Apadmi

@KevinnZou KCEF 2024.04.20.3 supports Ktor 3.x now

BTW since 2024.04.20.2 it's possible to use KCEF with the JetBrains JCEF JDK (so no downloading) however there is no working example how to set it up yet.

DatL4g avatar Oct 15 '24 11:10 DatL4g

I think we still need to merge this before closing this issue?

SamC-Apadmi avatar Oct 15 '24 13:10 SamC-Apadmi