compose-swipebox-multiplatform icon indicating copy to clipboard operation
compose-swipebox-multiplatform copied to clipboard

Material 3 support

Open mainrs opened this issue 1 year ago • 5 comments

Hello!

Having this library rely on material3 instead of material would allow for proper theming functionality (like dynamic themes) to work properly!

Thank you for the great library!

mainrs avatar Feb 15 '24 20:02 mainrs

@mainrs Thanks for your suggestion! I will upgrade it to Material3 when I am back from vacation.

KevinnZou avatar Feb 16 '24 02:02 KevinnZou

Thank you!

mainrs avatar Feb 16 '24 09:02 mainrs

@mainrs After researching, I discovered that the Modifier.swipeable we are using in this library is from Material2 and is not available in Material3. Therefore, unfortunately, we may not be able to upgrade to it currently.

KevinnZou avatar Feb 21 '24 01:02 KevinnZou

The API has actually been renamed and moved into foundation: https://developer.android.com/jetpack/compose/touch-input/pointer-input/migrate-swipeable

mainrs avatar Feb 21 '24 10:02 mainrs

Yes, we also noticed that and have just migrated to anchoredDraggable for the Android version of this library. We will also do it for the multiplatform version once Compose 1.6.0 is stable.

KevinnZou avatar Feb 22 '24 01:02 KevinnZou