material-react-table
material-react-table copied to clipboard
KevinVandy
fix: column right pin ruins menu order
column right pin pushes menu item to the bottom instead of keeping correct order
closes #1018
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| material-react-table | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 29, 2024 9:17am |
| material-react-table-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Feb 29, 2024 9:17am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
This way it is was by design. And if we were to get rid of it, we would just simplify the code to table.getAllLeafColumns, instead of splicing out the pinned indexes, only to recombine them like in this PR.
@KevinVandy What do you recommend, which approach to go with? I am fairly new to contributing, especially in projects of this size, and also with limited knowledge to lets say performance of something (junior, 1 year work experience). This way I would love to learn from your thoughts and recommendations if I am able to contribute of any sort.
This menu probably can be improved, especially for pinning. Just need to think about it a bit more.