Kevin Van Cott

Results 282 comments of Kevin Van Cott

@mleibman-db You can install `npm i https://pkg.pr.new/@tanstack/react-table@5927` right now to try out the preview NPM version in your code. For the alpha branch, it would need a redo instead of...

The scope of this pr to the main v8 branch is fine/good. However, the alpha v9 branch has been heavily refactored with new approaches to assigning APIs to these objects....

> Ok, so IIUIC, I'll leave this PR as-is to proceed with code review, testing, and inclusion in v8, and will look at v9 to see how things are different...

I'm not going to be able to fully review until at least Friday most likely. @tombuntus @riccardoperra might help more. As I said earlier, you should be able to install...

If anyone wants to install and test this PR in their own codebase, you can install the preview package down below. Find all of the other adapter preview versions under...

> @KevinVandy So all our tests are passing, with the exception of several instances where we essentially run into a similar issue I listed as a risk above. > >...

That makes sense. But to be clear, you are saying that anyone who is currently destructuring methods from rows and then tries to call them is going to get unexpected...

> If I may, is there any chance this change could be v9 and the current alpha become v10? That's actually becoming my plan. We're going to split up the...

It's not as easy as just changing the imports from `material-table` like `@material-table/core` is, but I built [Material React Table](https://www.material-react-table.com/) as a modern replacement to Material Table for my needs...

Hmmm, I think the fixed functionality is what actually makes sense here. You don't have to use this API if you want to check something else.