pytorch-adapt icon indicating copy to clipboard operation
pytorch-adapt copied to clipboard

Extending the Lightning class (pytorch_adapt/frameworks/lightning/lightning.py)

Open just-eoghan opened this issue 2 years ago • 1 comments

Suggested Feature

The Lightning class could be extended to include two more functions

  1. test_step
  2. test_epoch_end

Implementation

The test_step and test_epoch end could operate in the same way as the validation_step and epoch_end and return a test_score.

Reasoning

This would allow lightning users to specify a test_dataloader containing a hold-out set in their datamodule. The best saved model on validation data can then be run against the test data using pytorch lightning trainer.test function call.

just-eoghan avatar Apr 11 '22 15:04 just-eoghan

Makes sense

KevinMusgrave avatar Apr 11 '22 19:04 KevinMusgrave