uSync icon indicating copy to clipboard operation
uSync copied to clipboard

Handler settings are string-only in schema, so e.g., boolean settings, are reported as errors

Open kdx-perbol opened this issue 2 years ago • 2 comments

Describe the bug uSync Handler settings are string-only in the uSync appSettings schema, so e.g., boolean settings, are reported as errors.

To Reproduce Steps to reproduce the behavior:

  1. Follow https://docs.jumoo.co.uk/usync/uSync/guides/dictionary/#make-the-dictionary-handler-create-only
  2. Observe error squiggles

Expected behavior No squiggles. :)

About your Site (please complete the following information):

  • uSync Version: latest

Additional context

    "USyncBackOfficeConfigurationHandlerSettings": {
      "properties": {
        "Settings": {
          "additionalProperties": {
            "type": "string"
          }

kdx-perbol avatar Apr 17 '23 11:04 kdx-perbol

Putting true and ignoring squiggles for now.

kdx-perbol avatar Apr 17 '23 11:04 kdx-perbol

Hi,

yes this is because internally we are using a dictionary<string,string> for the settings and when the schema is generated, its picking that up. (it does work with ether true or "true",

Unfortunately changing this to dictionary<string, object> will be a breaking change - so we will have to wait for a major release to make the change.

KevinJump avatar May 11 '23 08:05 KevinJump