Kevin Cathcart
Kevin Cathcart
@frenck The issue title is "Multiple brand Icons not loading", and issue body also lists sensorpush, and smart_meter_texas as additional examples. I also noticed the other two, and mentioned the...
Missing icons are not a bug, but they are an "issue" (in the sense of something that ideally ought to get addressed at some point). It is never intentional nor...
Should this be an immediate breaking change, or merely adding the new sensors, while deprecating the attributes to be removed later? (I have no strong opinions). For the rest of...
Long term I do think the attributes should go away, so I would be good with formally deprecating them. I’m not sure it is actually feasible to warn about using...
Technically the original code would accept 0x00 0x7f under the dual byte character set ("Uncompressed"). But It would require a very unusual sequence in the variable byte encoding ("compressed") to...
Actually, this report was about item #$24 appearing in chests, and the keysanity dungeon item grid in the menu. When you open a chest containing that vinilla small key item...
One concern I see is that the implementation shown in the pull request will miss some deadlocks that only involve transaction locks, because it only queries the other silos once,...
While I appreciate the goal of having it be easy to do the correct thing and avoid accidental use of lingusitic operations, I have a lot of concerns here about...
> Considering that the schema returns the children, this defines a new "derivation" centric, tree shaped view of the flake that is determined by the flake itself, as the flake...
So I've looked into the `SimpleQueueCache` vs `ConcurrentQueueCache`. I'm not seeing problematic race conditions, because SimpleQueueCache is supposed to be called only from the PersistentStreamPullingAgent's thread. It is also fully...