Marc Plano-Lesay

Results 137 comments of Marc Plano-Lesay

Just my two cents: does it really matter? I'm not sure of the value of running linters on generated code. With that said, the only issue here seems to be...

Compiling gRPC-Kotlin with 1.4.3 was fine for me, as far as I can tell. Migrating to 1.5 will require a tiny bit of work at least: ``` stub/src/main/java/io/grpc/kotlin/ServerCalls.kt:269:34: warning: 'offer(E):...

`maven_jar` has been deprecated in Bazel 1.2.0 and removed in Bazel 2.0.0. This repo would need to be migrated off of this, using e.g. [rules_jvm_external](https://github.com/bazelbuild/rules_jvm_external). In the meantime, using an...

IMHO that's a nice technical demo, but not something that should really be used in apps - it's against user expectations on older Android versions to have the app using...

It might be interesting to have a slightly more involved logic and check the current version for those well-known qualifiers as well. For example, if the currently in use version...

> > but I dislike that it's not really integrated with the native dagger > > Can you elaborate on that? In my mind it would be just as easy...

I started looking into this earlier this week (https://github.com/ProdriveTechnologies/bazel-latex/issues/65#issuecomment-1216313145), there's quite a bit of work to be done to update TeXLive before this can be done. I'll be working on...

Fixed in #89 - released in v1.2.0.

I can't figure out why the test doesn't build - the only error I get is `failed to open file recorder output: [Errno 2] No such file or directory: 'lualatex.fls'`,...

When rebased ontop of #89, we get more details: ``` kpathsea: Running mktexpk --mfmode / --bdpi 600 --mag 1+0/600 --dpi 600 cookingsymbols mktexpk: don't know how to create bitmap font...