augustus icon indicating copy to clipboard operation
augustus copied to clipboard

Small visual bug with mausoleums and markets and their desirability.

Open Zeg4 opened this issue 2 years ago • 8 comments

This is a tiny and mostly inconsequential one that would be slightly misleading at worst, maybe making the player think they placed these buildings wrong at first.

image

When a small mausoleum is exactly 4 tiles away from a house (or a large one is 5 tiles away), the house considers it to be within range of the red part of the mausoleum's desirability, thus prompting the message about detrimental effects despite this not being true.

image

This should not show up since this range is the thin orange line shown above, which is positive desirability as shown by the tooltip. This does not happen for the small/large mausoleum at 5/6 tiles away, and it accordingly happens if 3/4 tiles away or closer.

image

I compared this to the market, the only other building with the same quirk, at 3 tiles of distance away from houses, and the same happens for it, despite that range being a neutral desirability value which would actually be positive for 2x2 houses in that range, so I guess this is on the vanilla game too.

That is the issue. My guess is that the game needs a minumum desirability value from these buildings specifically for it to not count as detrimental and not show the message, and since the value is low right after the negative end, it must think that it is still within the red part.

Zeg4 avatar Sep 04 '23 18:09 Zeg4

Hi, can you get me that save for testing please?

crudelios avatar Sep 05 '23 09:09 crudelios

Sure. I advanced the city a little since that point, but the mausoleum remains there along with the message, so it should be useful still.

Dropbox link

If the camera is not focused on the block on load, it is the one on the far right of the map. All 4 houses facing the mausoleum show the message.

Oh, and I am on the latest unstable build of Augustus.

Zeg4 avatar Sep 05 '23 15:09 Zeg4

I have tested the fix and, while it does work correctly for the example case on this issue, it seems to be a bit overcorrected, the issue now being the opposite: the game not showing the message when it should.

The most visibly evident case of this is with wells and prefectures, one-tile buildings with negative desirability that houses normally detect if they are in detrimental range with a message.

image

They are now not showing up at all, no matter the distance or quantity of them.

The tail-end of other buildings such as granaries 2 tiles away are also not showing up, and yes, mausoleums at 3 tiles range as well.

So, it seems like the game is now checking for a minimum value on the other direction instead.

Zeg4 avatar Sep 06 '23 16:09 Zeg4

Since that's the case I'm going to revert the change and mark this as unfixable. The game uses a crude approximation to detect the lowest desirability building and since this is a small informational pane it's not worth the hassle to properly fix.

crudelios avatar Sep 06 '23 16:09 crudelios

Got it. I was thinking the same, and the visual normally only affects markets and mausoleums, so it is definitely better to just leave it as is if the game is too limited for finer detection.

Thanks for looking into it regardless.

Zeg4 avatar Sep 06 '23 16:09 Zeg4

Was this change reversed yet? It looks the same on my game, though maybe I just copied the files incorrectly.

Zeg4 avatar Sep 16 '23 01:09 Zeg4

No I haven't reversed it yet. Though I said I would, I'm not happy with just reversing so I want to look into it to see if I can fix the issue for good, but I need time for that.

crudelios avatar Sep 16 '23 06:09 crudelios

Oh, I see. I mean, feel no pressure on that, though I do respect the commitment. I can relate to wanting to fix a small issue with code like that, for sure. But yes, take as much time as you need 👍

Zeg4 avatar Sep 16 '23 06:09 Zeg4