augustus icon indicating copy to clipboard operation
augustus copied to clipboard

Trading ships disappear right after entering the map.

Open Real-Gecko opened this issue 2 years ago • 6 comments

After I've build third dock trading ships entering the map disappear almost immediately. You can see them appear on the left part of the river for a brief period. Earlier save with only two docks present worked well for me. Caesar3.zip

Real-Gecko avatar Nov 11 '22 18:11 Real-Gecko

Is this your third dock? image

I think the issue is the ships can't figure out how to get there, so they immediately off themselves. I tried deleting that dock and building another one further down the shore and that seemed to work ok. Not sure if that's a bug in the original game or something that got introduced in Augustus.

PrettyFlower avatar Nov 11 '22 18:11 PrettyFlower

Is this your third dock?

Yes, that's it.

Not sure if that's a bug in the original game or something that got introduced in Augustus.

No way to debug?

Real-Gecko avatar Nov 11 '22 18:11 Real-Gecko

Looks like it is an Augustus specific issue. We'll have to compare the two to see what's going on. Here's a simpler test case to reproduce the issue. Disappearing trade ships OG.zip

PrettyFlower avatar Nov 11 '22 18:11 PrettyFlower

We've had this issue with that same map and a dock in that very same position.

It has to do with the fact that the game isn't very good a picking a spot where ships should queue and sometimes it picks a land tile.

When ships appear, they notice they can't sail there so they immediately disappear.

crudelios avatar Nov 11 '22 19:11 crudelios

After looking into this a bit, the thing that changed from the original game is ships used to look for a reachable dock location when entering the map, but now they look for a queue location instead. The "docked" locations for that dock are reachable by ships, but the queue locations are not, so the ships fail now. We could change it so ships look for a "docked" location first again, but the ship navigation code is pretty involved.

It should be noted that while ships could reach the "docked" position in the original game, as soon as a ship was docked there the exact same issue would happen for new ships, as they would be unable to reach the queue positions.

PrettyFlower avatar Nov 13 '22 01:11 PrettyFlower

Yes, we did make that change. The only way to fix this is to be more dynamic when searching for a valid "first queue"/"second queue tile".

I already improved this somewhat, but it's not perfect.

crudelios avatar Nov 13 '22 10:11 crudelios

I'm going to add a change which prevents people from building docks on such spots. It will not fix current problematic buildings but at least it will improve the issue.

crudelios avatar Dec 21 '22 21:12 crudelios

Issue is now prevented by dc63333290afd1e632eadfae36473a68762cc251, so I'm marking this as fixed.

crudelios avatar Dec 23 '22 09:12 crudelios