Thomas Mansencal

Results 237 comments of Thomas Mansencal

Hey @TimWalter, I haven't forgotten about that, been busy, very busy on many different projects so this got at the bottom of the stack. I look at your Notebook though,...

Hey @TimWalter, I'm working on this and I have a few notes / questions: - `is_convex_quadrilateral` definition is missing (it is not critical that said). - What value do you...

Just deleted a bunch of comments, I was not thinking clearly, long week... :)

Looking at the `are_three_collinear` definition should not the comparison be as follows in `generate_template` definition: `if np.all(angle_difference > 0) and not are_three_collinear_2(points)`, i.e. we add a correspondence only if it...

@TimWalter: I noted an issue in the definition that filters the stacked contours: It relies on the fact that the contours are ordered in a particular way by OpenCV. This...

Hey @TimWalter, I released a new version, I haven't incorporated your changes as I focused on a machine learning inference approach. That being said, I overhauled the segmentation method and...

Thanks for the replies! Would be neat to also have your method :)

I have updated the segmentation code and it should not produce doubled contours anymore.

It is worth noting that one of the reasons that those functions do not exist was to keep the classes lightweight thus one can trivially convert a `colour.SpectralDistribution` to a...

Hi Berk, Sorry for the late reply! I was on holidays break and working on other things. Are you still interested into implementing this? Cheers, Thomas