AbracaDABra icon indicating copy to clipboard operation
AbracaDABra copied to clipboard

Some MSVC/clang-cl build issues

Open gvanem opened this issue 1 year ago • 13 comments

Building AbracaDABra.exe using MSVC or clang-cl has been very easy (compared to e.g. Welle-IO or Qt-DAB (yuk!)). But I had some minor issues:

  • This triggers a warning in clang-cl: bool muteRequest = m_muteFlag | m_stopFlag; // false == do unmute, true == do mute Shouldn't it be bool muteRequest = m_muteFlag || m_stopFlag;? Same issue on line 791.
  • MSVC fails on lines like: #warning "Best ensemble to be implemented". But a #pragma message ("Best ensemble to be implemented") works. Looks like these are for internal use. So could they be dropped?

And PS, it would be nicer if the DAB date/time had seconds printed:

--- a/gui/mainwindow.cpp 2022-09-01 10:45:57
+++ b/gui/mainwindow.cpp 2022-09-01 12:43:24
@@ -694,7 +694,7 @@

 void MainWindow::updateDabTime(const QDateTime & d)
 {
-    timeLabel->setText(d.toString(QString("dddd, dd.MM.yyyy, hh:mm")));
+    timeLabel->setText(d.toString(QString("dddd, dd.MM.yyyy, hh:mm:ss")));
 }

gvanem avatar Sep 01 '22 11:09 gvanem