Tensorial.jl icon indicating copy to clipboard operation
Tensorial.jl copied to clipboard

on non-standard infix operators

Open ExpandingMan opened this issue 7 months ago • 3 comments

Hi, thanks for all your work on this very impressive package.

I was wondering if you would ever be willing to re-consider the use of infix operators in this package. In particular, the use of * and $\cdot$ are incompatible with the conventions of all other AbstractArray. You cannot, for example, replace an SMatrix with a Mat and have matrix multiplication still work. While I understand that the Tensor objects in this package are more general than StaticArrays and one is certainly not a drop-in replacement for the other, I nevertheless think it would go a long way to making this package more useful in the wider Julia ecosystem. Similarly, I have only ever seen $\cdot$ used as an inner product (i.e. having codomain $\mathbb{R}$), so I would expect $A \cdot B = \textrm{tr}(A^\dagger B)$ before simple matrix multplication.

I know this is a huge suggestion that might imply a lot of work, but I thought it worth mentioning as I very much doubt I am the only one who would hesitate to use this particularly because of differences in convention not only with StaticArrays but with AbstractArray types more generally.

ExpandingMan avatar Jun 28 '24 18:06 ExpandingMan