GodotAddonPack icon indicating copy to clipboard operation
GodotAddonPack copied to clipboard

Obligitory Godot 4 Issue!

Open croxis opened this issue 4 years ago • 7 comments

Godot 4 changes things. This issue is for a Godot 4 compatible pack!

croxis avatar Nov 21 '21 17:11 croxis

For Godot 4 I intend to migrate everything that is relevant to GDExtensions the moment it allows an extension to have dependencies on other extension(s).

When I say relevant, things that don't get core implementations. As an example, the EncDecBuffer is probably not going to be necessary as I believe byte arrays will provide the necessary functionality.

Kehom avatar Nov 21 '21 19:11 Kehom

And I saw some networking improvements too. Is there a pull request/issue for the extension dependencies?

croxis avatar Nov 23 '21 02:11 croxis

I'm not aware of any pull request related to that. However I do know there are plans to make a GDExtension depend on another one.

Nevertheless, after Godot 4 final release, if it doesn't come with this feature I might consider following a different strategy to develop the "addons", in which the pre compiled version will contain every single implemented addon, while the compilation script should offer means to disable those that aren't desired/required.

Kehom avatar Nov 23 '21 12:11 Kehom

Hello Kehom,

I have just ported the DebugLine3D code to Godot 4 since I wanted something similar anyway. I would be happy to open a PR for it if you want to see the changes. I think this one is a very straightforward conversion, and not necessary to use C++ since it's only for debug purposes anyway.

Rodeo-McCabe avatar Mar 07 '22 13:03 Rodeo-McCabe

I have just ported the DebugLine3D code to Godot 4 since I wanted something similar anyway. I would be happy to open a PR for it if you want to see the changes. I think this one is a very straightforward conversion, and not necessary to use C++ since it's only for debug purposes anyway.

Hello! Does the conversion break compatibility with current stable version of Godot? If not then please feel free to open the PR! Otherwise a new branch has to be created, but to be honest I might prefer to wait for a little more stability over the API. I believe a good time to start working on conversions for Godot 4.0 is when it reaches beta status.

Indeed, the debug helpers are probably better left in pure GDScript.

Kehom avatar Mar 07 '22 14:03 Kehom

Oh yes, it is NOT compatible with 3.x so I will wait until a branch is created for it. I'll check back around the time the 4.0 beta is released, and I'll make sure it's all on the up and up before I make the PR.

Rodeo-McCabe avatar Mar 08 '22 02:03 Rodeo-McCabe