android-resource-remover icon indicating copy to clipboard operation
android-resource-remover copied to clipboard

Published 20 hours ago • verified publisher icon KeepSafe

Support removal of arrays

Open timrae opened this issue 9 years ago • 8 comments

Match patterns such as "string-array" that would previously only return "array", and subsequently fail in remove_resource_value

timrae avatar Apr 01 '15 15:04 timrae

Just fixed a little error, sorry about that

timrae avatar Apr 01 '15 15:04 timrae

I am getting this error:

NameError: global name 'errorLine1' is not defined

friederbluemle avatar May 06 '15 00:05 friederbluemle

Oops I think I had pasted the patch via the web interface... Looks like I forgot something. I'll edit soon

timrae avatar May 06 '15 00:05 timrae

I added the missing lines but that's broken the unit tests... I'll have to take a look later as I don't have time at the moment. Feel free to fix it up yourself and close the PR if you have time

timrae avatar May 06 '15 01:05 timrae

Hi @timrae you think you'll find time to fix the tests? would love to merge it.

philippb avatar Nov 11 '15 04:11 philippb

@philippb sorry I don't have time at the moment. I briefly looked into it at the time of posting and it seemed non-trivial so I never ended up getting around to it. I might do it sometime next year if I end up needing to use the script again. I'd recommend fixing it yourself if you have the time and motivation!

timrae avatar Nov 11 '15 04:11 timrae

@timrae thanks for the reply. We'll look into it.

philippb avatar Nov 11 '15 20:11 philippb

Right now we don't have the time to fix this, it's worth looking into in the future

ca77y avatar Nov 17 '15 11:11 ca77y