ReLinker icon indicating copy to clipboard operation
ReLinker copied to clipboard

Include report of unscannable files in MissingLibraryException

Open MrHadiSatrio opened this issue 1 year ago • 0 comments

What has changed

To reduce ambiguity, we would want to report unscannable files whenever we're querying for getSupportedABIs(). This is done by:

  1. Employing an object which could store problematic Files information in addition to the supported ABIs.
  2. Modifying getSupportedABIs()'s catch clause to capture said information.
  3. Modifying MissingLibraryException to report it.

Additionally, to ease testing, refactor ZipFile factory logic out from ApkLibraryInstaller so we can mock this scenario.

Sample exception message post this change

Could not find 'libtest.so'. Looked for: [armeabi-v7a], but only found: []. Additionally, encountered errors while scanning: [fake.apk => java.io.IOException: Could not create zip file.].

Why it was changed

As an attempt to resolve #107.

MrHadiSatrio avatar May 02 '24 09:05 MrHadiSatrio