KeeProMise comments

Results 62 comments of


                                            KeeProMise

[Serve] log deployment config in controller logs

> > > These changes seem overly complex for a simple task like logging config. Is there a architectural reason why logging just the deployment config is difficult? > >...

[Serve] log deployment config in controller logs

> please add screenshot of manual test after this change.

[Serve] log deployment config in controller logs

@abrarsheikh Thank you for reviewing and merging this PR.

[core] Improving the error handling for @ray.remote and @ray.method with num_returns.

> @KeeProMise thank you for the contribution. All of the input validation logic is in [ray_option_utils.py](https://github.com/ray-project/ray/blob/3a0eb96b78f8e40d635c5ef15c609772f0aa39f5/python/ray/_common/ray_option_utils.py#L4). Can you PTAL at that file and make the change there? Hi @israbbani Thank...

[core] Improving the error handling for @ray.remote and @ray.method with num_returns.

Hi @israbbani @edoakes if you have time, please help to take a look at this PR, thanks!

[core] Improving the error handling for @ray.remote and @ray.method with num_returns.

> I think we need to rethink the approach here a little bit. Please take the time to review the code for the decorators and let's design a wholistic solution....

[core] Improving the error handling for @ray.remote and @ray.method with num_returns.

Hi @israbbani @edoakes All tests passed. if you have time, please help to take a look at this PR, thanks!

HDFS-17602. RBF mount point with SPACE order can not find the most available namespace, it will choose an irrelevant namespace

Hi, @wzk784533 For the failure of test4tests, you need to add a UT

HDFS-17602. RBF mount point with SPACE order can not find the most available namespace, it will choose an irrelevant namespace

@wzk784533 Hi, thanks for you contribution, LGTM, @Hexiaoqiao @goiri If you have time, please help to take a look.

HDFS-17602. RBF mount point with SPACE order can not find the most available namespace, it will choose an irrelevant namespace

> @KeeProMise Could you please merge this pull request, or is there anything else I shoud do please let me know Hi, @wzk784533 thanks for your contribution, LGTM, but I...