Keavon Chambers

Fantastic!

!build

I found a crash in this configuration: That's text fully inside a rectangle underneath it, using the Subtract Back mode. ``` error frontend/wasm/src/lib.rs:42 Node graph evaluation panicked panicked at /var/lib/github-actions/.cargo/git/checkouts/linesweeper-1dbd5502625f3a9a/e39ba9b/src/segments.rs:384:17:...

Within Graphite or Linesweeper? It is certainly possible we're producing non-correct rectangles.

!build

Unfortunately it looks like this isn't quite a drop-in replacement with identical behavior: https://github.com/user-attachments/assets/b362ae10-6df3-4a40-8be1-4ea624d1ae1e I don't necessarily know which implementation is more correct with the input data it's given for...

Crash: ``` error frontend/wasm/src/lib.rs:45 Node graph evaluation panicked panicked at /var/lib/github-actions/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/linesweeper-0.1.0/src/sweep/sweep_line.rs:625:14: called `Option::unwrap()` on a `None` value ``` Here's the file: [linesweeper_crash.graphite.txt](https://github.com/user-attachments/files/23406890/linesweeper_crash.graphite.txt) This happened when I cranked the number of...

@adamgerhant in that situation, could you please remember to leave an approval on the PR? Thanks :)

Sorry, what issue or `#code-todo-list` task is this solving? The PR description is blank and the title doesn't give me enough details to understand what this is meant to fix.

Ah, cool, thanks. Yeah, that looks useful. I put that in the PR description. This will need to have its conflicts resolved against master but then I can code review...