Vincent Prouillet comments

Results 1383 comments of


                                            Vincent Prouillet

Would it be possible to make DecodingKey more test friendly?

We can implement `PartialEq` but if we implement a `Debug` it should be a custom implementation that just prints the algorithm and _not_ the data contained in it to avoid...

Would it be possible to make DecodingKey more test friendly?

Let's not implement `PartialEq` actually, only a custom `Debug`: https://github.com/Keats/jsonwebtoken/issues/220

Add support for the reject_tokens_expiring_in_less_than option.

I'll merge and release in a bit when i have some free time

Add support for the reject_tokens_expiring_in_less_than option.

Looks like there's another MSRV >_>

Add support for the reject_tokens_expiring_in_less_than option.

Thanks and sorry for the delay

src/pem as a separate crate?

I'm not going to export it as a separate crate but someone else could create a new crate and publish it (we wouldn't use it here though)

Adding secrecy or zeroize for EncodingKey and DecodingKey

You mean in a custom `Drop` impl? I've used zeroize before so i would lean towards that

Make family public

Can you add a snippet of how you would use that?

Document that "exp" field is required

It's required if you don't turn it off in the https://docs.rs/jsonwebtoken/latest/jsonwebtoken/struct.Validation.html struct

How to customize the Header field

You can't, you can only use header fields from the spec in this library