Vincent Prouillet comments

Results 1383 comments of


                                            Vincent Prouillet

Isolate chrono use from rest of "builtins" features

Is there a crate doing strftime handling for `time`?

Isolate chrono use from rest of "builtins" features

I've already replaced chrono with time in a few projects, it's just that Tera uses `strftime` so unless there is a crate for that with `time`, I'm not going to...

Isolate chrono use from rest of "builtins" features

Hm it might work! I (or someone else if they have time) should check how easy it is to replace the current chrono usage with time + time-fmt

spaceless feature should be a tag rather than a filter

I guess it would become `Foo`?

spaceless feature should be a tag rather than a filter

> So, I'll suggest this really ought to be deprecated because its a bad idea all around. Likely to be removed for v2.

Extends does not work when template has BOM

Ah damn, must be something in the grammar...

undefined test has weird behavior with an Option<T>

If I understood correctly, it's the expected behaviour. `y` is defined as `None`, `{%- if foo.x.z is undefined %}` should throw though, assuming there's no field named `z`.

undefined test has weird behavior with an Option<T>

I will need to double-check, the `undefined` test code seem like it should fail on that but I haven't looked at that part of the code in a long time.

Passing a variable into the parent template

In Tera, template outside of blocks is completely ignored in children. The way to do it here is to define a block in your parent template and override it in...

Speed up CallStack::lookup

> Another possible speedup would be turning everything into JSON pointers at template parse time, and storing those. I like that idea, probably for v2 though