Vincent Prouillet
Vincent Prouillet
There's https://github.com/Keats/jsonwebtoken/pull/402 which is the start of the same idea minus traits. The idea was to support aws-lc-rs and rust-crypto. I didn't consider traits but i guess it would work...
https://github.com/Keats/jsonwebtoken/pull/318 has been merged on the next branch as well. As for doing the PR, you can see with @GlenDC what he prefers
https://github.com/Keats/jsonwebtoken/pull/410 is definitely the way to go. It's missing some stuff but the base is there and it should be possible to finish it.
See https://github.com/Keats/jsonwebtoken/issues/220
That looks like a raw serde_json error. We need to see if we can provide a better one
I think we can have both the builder and the function?
> I both cases I was visualizing that we keep the same functionality of the original functions [1], but the internal business logic of these functions would either be provided...
Go ahead, we can play with the DX once it's implemented. Maybe use macros to implement them so it's easy to make changes if needed rather than copy/paste
They are used by some people who only care about the crypto primitives so I would re-implement them and keep them pub
Hi @sidrubs will you have time to finish that PR?