HacKeYthon: Improved Taclet Options

[tobias-rnh]

Related Issue

This pull request addresses #3414.

Intended Change

Remove the old dialog to change taclet options. Taclet options can now be accessed through the new unified settings dialog ("Options" -> "Show Settings" -> "Taclet Options"). Additionally, a bug was fixed where a warning header did not disappear, even after a proof was loaded.

As of now, the radio buttons selected are still only the default ones and not the options selected in the current proof.

Type of pull request

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] Refactoring (behaviour should not change or only minimally change)
• [ ] New feature (non-breaking change which adds functionality)
• [x] Breaking change (fix or feature that would cause existing functionality to change) Old Taclet Options are not accessible through the options tab directly anymore
• [x] There are changes to the (Java) code
• [ ] There are changes to the taclet rule base
• [ ] There are changes to the deployment/CI infrastructure (gradle, github, ...)
• [ ] Other:

Ensuring quality

• [x] I made sure that introduced/changed code is well documented (javadoc and inline comments). Really only inline comments
• [ ] I made sure that new/changed end-user features are well documented (https://github.com/KeYProject/key-docs).
• [ ] I added new test case(s) for new functionality.
• [x] I have tested the feature as follows: I manually inspected the menus and how they behaved before and after loading a proof
• [ ] I have checked that runtime performance has not deteriorated.

Additional information and contact(s)

As a reference, how things were looking before and now:

The options tab previously had an entry to get to taclet options directly.

Now, this is not the case anymore since the options are now contained in a unified settings dialog.

Before, even when a proof was loaded, there was still a header shown in the taclet options stating that there was no proof loaded.

This is fixed now.

At "Proof"->"Show Active Taclet Options" you can see the active taclet options with a path given at the bottom to change the taclet options.

Now, the path to the taclet options has been changed to reflect the new way to change taclet options.

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.