asm2cfg icon indicating copy to clipboard operation
asm2cfg copied to clipboard

Add riscv Architecture and cfg show address & source code

Open x213212 opened this issue 2 years ago • 7 comments

Add riscv Architecture and cfg show address & source code image

x213212 avatar Dec 02 '22 03:12 x213212

This pull request introduces 4 alerts when merging bee98cccb641b2bcaf5909ad3333c0dea364e7a8 into fe700c395283b9cc1a810e29ecdf5fae407be4c6 - view on LGTM.com

new alerts:

  • 2 for Wrong number of arguments in a call
  • 1 for Testing equality to None
  • 1 for Duplication in regular expression character class

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 02 '22 03:12 lgtm-com[bot]

Add tarjan algorithm Detection domator tree find loops Add experimental color cfg

x213212 avatar Dec 02 '22 04:12 x213212

This pull request introduces 17 alerts when merging edf2e2692461221c7dc3b0f05e87d1b442ef749f into fe700c395283b9cc1a810e29ecdf5fae407be4c6 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 5 for Unused local variable
  • 2 for Wrong number of arguments in a call
  • 1 for Testing equality to None
  • 1 for Duplication in regular expression character class
  • 1 for Variable defined multiple times
  • 1 for Nested loops with same variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 02 '22 04:12 lgtm-com[bot]

python3 -m src.asm2cfg -er -c examples/riscv-huge.asm

x213212 avatar Dec 02 '22 05:12 x213212

This pull request introduces 17 alerts when merging 86cb96a028d8f4c10e83920a4bc2d701126076ab into fe700c395283b9cc1a810e29ecdf5fae407be4c6 - view on LGTM.com

new alerts:

  • 6 for Unused import
  • 5 for Unused local variable
  • 2 for Wrong number of arguments in a call
  • 1 for Testing equality to None
  • 1 for Duplication in regular expression character class
  • 1 for Variable defined multiple times
  • 1 for Nested loops with same variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Dec 02 '22 05:12 lgtm-com[bot]

I suggest to split PR to standalone commits to simplify review.

yugr avatar Dec 02 '22 07:12 yugr

I also checked this PR now and it's indeed quite huge. Could you add them to separate commits or feature per PR? Also file src/asm2cfg/asm2cfg.py is growing in size quite a lot. You're welcome to try split some parts of it like you already done with utils.py. If not then this can be done on later PRs as well. One problem with the splitting is making sure this project still works as a GDB plugin. If I remember correctly there might be some problems with import paths.

Kazhuu avatar Dec 06 '22 11:12 Kazhuu