vue-simple-suggest icon indicating copy to clipboard operation
vue-simple-suggest copied to clipboard

Warning "Please provide `display-attribute`" is shown initially

Open schnetzi opened this issue 4 years ago • 4 comments

I'm submitting a ...

  • [x] bug report
  • [ ] feature request
  • [ ] support request

What is the current behavior?

Currently a warning is shown when v-model is missing which says [vue-simple-suggest]: Please, provide display-attribute as a key or a dotted path for a property from your object.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem

I created a codesandbox where you can see that behaviour. https://codesandbox.io/s/simple-suggest-warning-28hht?fontsize=14&hidenavigation=1&theme=dark

If you go to components/SimpleSuggest.vue and remove line 4 (v-model="inputString") you will see a warning popping up in your console. Refresh the browser and it is still there. Adding it again and refreshing the browser will solve the issue.

What is the expected behavior?

I have two different ideas:

  1. The warning message will be something more related to the problem.
  2. No warning message as it is not necessarily needed.

How are you importing Vue-simple-suggest?

  • [ ] ESNext (original code, single-file .vue component, css included) (import VueSimpleSuggest from 'vue-simple-suggest/lib')
  • [x] ES6 (import VueSimpleSuggest from 'vue-simple-suggest')
  • [ ] ES7 and above (import VueSimpleSuggest from 'vue-simple-suggest/dist/es7')
  • [ ] Bundled version (import VueSimpleSuggest from 'vue-simple-suggest')
  • [ ] CommonJS (const VueSimpleSuggest = require('vue-simple-suggest'))
  • [ ] UMD Component (<script type="text/javascript" src="https://unpkg.com/vue-simple-suggest"></script>)

What is the motivation / use case for changing the behavior?

Let people find the problems for warnings more easily. Keep warnings from appearing if there is no need for them.

Please tell us about your environment:

  • Vue.js Version: 2.6.11
  • Vue-simple-suggest version: 1.10.1
  • Browser: [all]
  • Language: [all]
  • Other information It wasn't a problem in version < 1.10

schnetzi avatar Jan 22 '20 14:01 schnetzi

Hello, @schnetzi We have recognized this issue as a bug and will attempt to solve it ASAP.

kaskar2008 avatar Jan 30 '20 15:01 kaskar2008

What happened with that case? :)

goshku avatar Sep 20 '20 00:09 goshku

@gstamosbg COVID has displaced our priorities :( Looking forward to fix all the issues tho.

kaskar2008 avatar Sep 24 '20 13:09 kaskar2008

Any updates on this?

vencho-mdp avatar Feb 08 '22 01:02 vencho-mdp