Conflict with Wings Mod

[llazzllo]

Something is conflicting with the mod Wings, causing a strange visual glitch when you fly. your wings disappear, and you fly upside down. It's only noticeable in third person view in singleplayer, or when watching someone else fly in LAN or on a server.

[Kaydax]

Can you link me to the mod in question?

[llazzllo]

It's this one:

https://www.curseforge.com/minecraft/mc-mods/wings

[Kaydax]

I will look into this, but you should also post an issue on their github to let them know of the incompatibility

[llazzllo]

Will do, thanks.

[pau101]

Author of Wings here, it appears the issue comes from Ido's logic for intercepting render for just if the height of the player is 0.6. This is true while flying with an Elytra or my wings. https://github.com/Kaydax/Ido/blob/0a995323fc8557e32d6deb124487f0dfe6b0caaa/src/main/java/xyz/kaydax/ido/handler/ClientHandler.java#L47

Something else I noticed while reading this code is Ido is leaking video memory by constructing a RenderPlayerSwiming each render with subsequent ModelSwimingPlayer renders. ModelRenderers allocate a display list for rendering and there is no mechanic for disposing them. There has to be caching of RenderPlayerSwiming similar to how it is normally handled.

[Kaydax]

Author of Wings here, it appears the issue comes from Ido's logic for intercepting render for just if the height of the player is 0.6. This is true while flying with an Elytra or my wings.

https://github.com/Kaydax/Ido/blob/0a995323fc8557e32d6deb124487f0dfe6b0caaa/src/main/java/xyz/kaydax/ido/handler/ClientHandler.java#L47

Something else I noticed while reading this code is Ido is leaking video memory by constructing a RenderPlayerSwiming each render with subsequent ModelSwimingPlayer renders. ModelRenderers allocate a display list for rendering and there is no mechanic for disposing them. There has to be caching of RenderPlayerSwiming similar to how it is normally handled.

I will note this for the big update as I am working towards refactoring many of the code to make the mod more efficient

[kil0byt3]

Hi @Kaydax - any movement on this? We'd love to use Wings and Ido together in Rebirth of the Night, but this incompatibility is getting in the way of that a bit

[SandwichHorror]

Seconded there! Both great mods we'd love to use together, a patch would be greatly appreciated.

[Kaydax]

I am busy with other projects but plan to do a complete rewrite of the mod soon to have better support with other mods

[kil0byt3]

okay! do you think that would be sometime in the next 2-3 months, or longer? Just so we can gauge what we'll do for our modpack for the next update

[Kaydax]

Working on the rework now, expect this to be fixed in the coming week

[Cenadros]

Hi @Kaydax - I just got into this issue today. Trying to play with Ido and Wings and the flying animation does not work. I see the issue is still open. Are there any news on this?

Thanks.

[Kaydax]

Hi @Kaydax - I just got into this issue today. Trying to play with Ido and Wings and the flying animation does not work. I see the issue is still open. Are there any news on this?

Thanks.

Im reworking the entire mod from the ground up which is going to take some time.

[RedRaspberry]

Hi @Kaydax , I was just wondering if there's been any progress on the mod rewrite, or a fix for this issue. I don't intend to be rude here but it has been several months without an update to an issue open for over 2 years. Take your time though, I don't want to rush you if it's stressful or anything. Thanks.

[Kaydax]

Hi @Kaydax , I was just wondering if there's been any progress on the mod rewrite, or a fix for this issue. I don't intend to be rude here but it has been several months without an update to an issue open for over 2 years. Take your time though, I don't want to rush you if it's stressful or anything. Thanks.

I have lost interest in minecraft and minecraft modding in general, so progress is pretty much at a halt. However I have talked with the FutureMC developer to see if he could take the work done here and add all the features into that mod. I will update the curseforge page and this github page if anything comes of that, but I also know he is busy as is

[RedRaspberry]

That's understandable, thanks for the reply. Hopefully futureMC folds the features into itself, but I guess that's a "wait and see". Would you consider updating the curseforge page to state that the mod is no longer receiving updates (or similar disclaimer)?