Ido icon indicating copy to clipboard operation
Ido copied to clipboard

[Sticky] Known issues list

Open Kaydax opened this issue 5 years ago • 5 comments

Here are all the known issues:

Multiplayer:

  • [ ] Choppy movement when crawling / swimming
  • [x] ~~Other players will seem to be crawling when very close to a block or wall. This effect only appears happen on other players and seems to a be client side issue~~ [Fixed - 1.0.6]
  • [ ] If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

Singleplayer:

No issues currently exist for just singleplayer

Both:

  • [ ] The mod has terrible compatibility with mods that use the RenderPlayer class
  • [ ] Closing yourself inside of a door or fence gate will cause the player to start crawling
  • [x] ~~Sitting on stairs using Quark causes the player to crawl under the stair block~~ [Fixed - 1.0.4]
  • [x] ~~Using C&B and walking on custom blocks causes the player to crawl~~ [Fixed - 1.0.6]
  • [x] ~~Boats and minecarts are wonky with the mod~~ [Fixed - 1.0.4]
  • [x] ~~Spectator cannot fly down through blocks~~ [Fixed - 1.0.1]
  • [x] ~~Hitting your head on a ceiling causes the player to sneak for a split second~~ [Fixed - 1.0.2]
  • [x] ~~The Hat, Jacket and Sleeves layers are broken and are not animated with the body~~ [Fixed - 1.0.3]

Kaydax avatar Jul 23 '19 04:07 Kaydax

If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

You're using mc's renderViewEntity instead of the player from the event (for some or possibly no reason): https://github.com/Kaydax/Ido/blob/cc2af3b988ec2b02b696567cbbecac506e0651ed/src/main/java/xyz/kaydax/ido/handler/ClientHandler.java#L49-L53

Johni0702 avatar Aug 04 '19 07:08 Johni0702

If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

You're using mc's renderViewEntity instead of the player from the event (for some or possibly no reason): https://github.com/Kaydax/Ido/blob/cc2af3b988ec2b02b696567cbbecac506e0651ed/src/main/java/xyz/kaydax/ido/handler/ClientHandler.java#L49-L53

You just helped out a lot, thanks!

Kaydax avatar Aug 06 '19 20:08 Kaydax

If a player has a different skin type from yours, alex or steve, their arm size will be the same as yours causing a visual issue

      // Minecraft.getMinecraft().getRenderViewEntity()
      if (event.getEntity() instanceof AbstractClientPlayer)
      {
        AbstractClientPlayer client = ((AbstractClientPlayer) event.getEntity());
        type = client.getSkinType().equals("slim");
      }

Maybe checking type like this can fix the issue (not tested).

yezhiyi9670 avatar Feb 25 '20 02:02 yezhiyi9670

Closing yourself inside of a door or fence gate will cause the player to start crawling

Checking if the action of "Start crawling" is no use before making the player crawl. However a player should be allowed to continue crawling of sneaking if it is stuck in a block.

EDIT: I went to see mechanics about this in 1.14. The player will not start crawling if the player will still be colliding with a block after beginning to crawl. When the player is already stuck in a block and will still be colliding with a block after beginning to sneak, the player will not sneak automatically, and will not be allowed to start sneaking as well. If a player close itself inside a door while sneaking and release the sneak key, the player will not stand up but its speed will be unaffected.

yezhiyi9670 avatar Feb 25 '20 02:02 yezhiyi9670

I'm working on a mod using RenderPlayer class to change players' models, and I noticed my mod's poor compatibility with Ido. I suggest to use forge's capability system to implement a Ido switch on player, so other mods can simply disable Ido's function on certain players when conflicts happen.

kappa-maintainer avatar Apr 26 '20 15:04 kappa-maintainer