kava icon indicating copy to clipboard operation
kava copied to clipboard

Should auctions enforce a min bid duration greater than zero

Open karzak opened this issue 4 years ago • 1 comments

Setting BidDuration to zero (or any int < blockTime) means that any bid on an auction will trigger it's close in the next block. If BidDuration is a governance param that can be changed by a committee member, I would favor enforcing something like MinAllowedBidDuration = time.Second * 600 to prevent auctions from closing very rapidly in the case of a governance attack.

karzak avatar Apr 11 '20 15:04 karzak

This sounds sensible. It could be implemented as a committee permission. The permission would only allow committee proposals that have BidDuration > some amount. But maybe we want the minimum hardcoded in the module.

rhuairahrighairidh avatar Apr 13 '20 15:04 rhuairahrighairidh